Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disclosure #1068

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: disclosure #1068

wants to merge 15 commits into from

Conversation

ethanalvizo
Copy link
Contributor

@ethanalvizo ethanalvizo commented Dec 18, 2024 •
edited
Loading

Closes #1037

@ethanalvizo ethanalvizo self-assigned this Dec 18, 2024
@ethanalvizo ethanalvizo marked this pull request as ready for review December 26, 2024 21:06
@ethanalvizo ethanalvizo requested a review from mofojed December 31, 2024 20:52
margaretkennedy
margaretkennedy previously approved these changes Jan 3, 2025
View reviewed changes
mofojed
mofojed reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update plugins/ui/src/js/package.json to use the v102 versions of the @deephaven/ packages that include Disclosure to fix the build errors.

@ethanalvizo ethanalvizo requested a review from mofojed January 17, 2025 21:29
mofojed
mofojed requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add Disclosure to e2e tests as well. Would be cool to add your own e2e test instead of the render_all catchall.

plugins/ui/docs/components/disclosure.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/disclosure.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/disclosure.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/disclosure.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/disclosure.md Show resolved Hide resolved
plugins/ui/docs/components/disclosure.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/disclosure.md Show resolved Hide resolved
plugins/ui/src/js/src/widget/WidgetUtils.tsx Show resolved Hide resolved
@ethanalvizo ethanalvizo requested a review from mofojed January 27, 2025 14:18
ethanalvizo
ethanalvizo commented Feb 3, 2025
View reviewed changes
tests/app.d/ui_render_all.py Outdated
@@ -71,6 +71,7 @@ def ui_components1():
ui.flex("Flex default child A", "Flex default child B"),
ui.flex("Flex column child A", "Flex column child B", direction="column"),
ui.form("Form"),
ui.disclosure(title="Heading", panel="Content"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I add this do I not need to update the e2e snapshots? I ran the command locally and no snapshots were updating

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be too many components in that panel, causing yours to be in the overflow and not showing in the snapshot. Try adding it to one of the other panels.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this did the trick thank you!

@ethanalvizo ethanalvizo requested a review from mofojed February 3, 2025 05:57
mofojed
mofojed requested changes Feb 3, 2025
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Eric mentioned, you'll need to add it to another panel and update the snapshots for the e2e tests. Or add it as a separate component and add a new test for it.

@ethanalvizo ethanalvizo requested a review from mofojed February 5, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericlln ericlln ericlln left review comments

@mofojed mofojed mofojed approved these changes

@margaretkennedy margaretkennedy margaretkennedy left review comments

Assignees

@ethanalvizo ethanalvizo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui.disclosure
4 participants
@ethanalvizo @mofojed @margaretkennedy @ericlln